Remove UsageFunc dispatch from DefaultUsage to fix infinite recursion#16
Closed
Remove UsageFunc dispatch from DefaultUsage to fix infinite recursion#16
Conversation
…recursion (#15) DefaultUsage now always produces the default output, making it composable from within a UsageFunc. The UsageFunc dispatch is moved to ParseAndRun. Co-authored-by: mfridman <6278244+mfridman@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Discuss options to resolve issue 15
Remove UsageFunc dispatch from DefaultUsage to fix infinite recursion
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DefaultUsagechecksUsageFuncand calls it if set, making it impossible to callDefaultUsagefrom within aUsageFuncwithout infinite recursion. The function name implies "give me the default behavior" but instead re-dispatches to custom logic.Changes
usage.go: Remove theUsageFuncguard fromDefaultUsageso it always produces default outputrun.go: MoveUsageFuncdispatch toParseAndRun— checkUsageFuncfirst on help, fall back toDefaultUsageThis makes
DefaultUsagecomposable:Previously required a workaround of nilling out
UsageFuncbefore callingDefaultUsage.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.